You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the future, TMB pois will have adjusted dates for specific cases, being returned from the main server with year 1970. This way we can identify them to adjust checking opening time and rendering.
before
after
In order to test with the POI Eiscafé "Zur Postmeile" you need to set the TMB_YEAR_TO_PARSE to 2020.
- main server returns special TMB data with the year
of 1970, that we will be able to parse in order to
check for correct opening times
- added jest tests
- added expo linking mock for running test successfully
- removed `only` flag for jest test to run all in that
file
- added weekday to two checks to fulfill requirements
SVA-985
Enhanced Date Parsing in openingHoursHelper.ts
We've added 'TMB_YEAR_TO_PARSE' and 'dateWithCorrectYear' functions which help decipher the correct year from our date information. This boosts the accuracy of our time-based functionality.
Tests for Newly Added Date Parsing Function
We've also introduced tests for the 'dateWithCorrectYear' function. These validate the functionality and help ensure reliable operations.
Tweak to OpeningTimesCard.js
A new flag 'withoutYear' has been introduced in OpeningTimesCard.js. Depending upon the value of 'TMB_YEAR_TO_PARSE', this flag will help determine the correct date format.
Update to momentFormat Import in OpeningTimesCard.js
The import was updated to recognize 'TMB_YEAR_TO_PARSE', enhancing the efficiency of date and time processing.
Update to isOpeningTimeForDate Function
The function in openingHoursHelper.ts is now equipped to handle correct year parsing, thus providing more reliable outcomes associated with opening times.
Mock Update in jest-setup.js
To streamline testing, jest-setup.js has been updated to mock 'expo-linking' module using a 'createURL' function.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the future, TMB pois will have adjusted dates for specific cases, being returned from the main server with year 1970. This way we can identify them to adjust checking opening time and rendering.
In order to test with the POI Eiscafé "Zur Postmeile" you need to set the
TMB_YEAR_TO_PARSEto 2020.SVA-985